github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 06:51:27 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: properly set notification levels on group invite

Browse Source 
Previously we relied on side effects to set tracking state correctly
when inviting groups to messages

Also has a minor optimisation in that we use pluck instead of pulling in
full record
This commit is contained in:
Sam Saffron
2019-08-16 18:23:51 +10:00
parent a590061aae
commit 9a9e31f927
4 changed files with 25 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/topic_creator.rb
View File

@ -84,21 +84,8 @@ class TopicCreator
topic.notifier.watch!(tau.user_id)
end
topic.reload.topic_allowed_groups.each do |tag|
tag.group.group_users.each do |gu|
next if gu.user_id == -1 || gu.user_id == topic.user_id
action =
case gu.notification_level
when TopicUser.notification_levels[:tracking] then "track!"
when TopicUser.notification_levels[:regular] then "regular!"
when TopicUser.notification_levels[:muted] then "mute!"
when TopicUser.notification_levels[:watching] then "watch!"
else "track!"
end
topic.notifier.public_send(action, gu.user_id)
end
topic.reload.topic_allowed_groups.each do |topic_allowed_group|
topic_allowed_group.group.set_message_default_notification_levels!(topic)
end
end