mirror of
https://github.com/discourse/discourse.git
synced 2025-05-30 07:11:34 +08:00
DEV: introduce new API to look up dynamic site setting
This removes all uses of both `send` and `public_send` from consumers of SiteSetting and instead introduces a `get` helper for dynamic lookup This leads to much cleaner and safer code long term as we are always explicit to test that a site setting is really there before sending an arbitrary string to the class It also removes a couple of risky stubs from the auth provider test
This commit is contained in:
@ -267,11 +267,7 @@ RSpec.describe SessionController do
|
||||
SiteSetting.enable_sso = true
|
||||
SiteSetting.sso_secret = @sso_secret
|
||||
|
||||
# We have 2 options, either fabricate an admin or don't
|
||||
# send welcome messages
|
||||
Fabricate(:admin)
|
||||
# skip for now
|
||||
# SiteSetting.send_welcome_message = false
|
||||
end
|
||||
|
||||
let(:headers) { { host: Discourse.current_hostname } }
|
||||
|
Reference in New Issue
Block a user