github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 23:58:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Improve error when trying to edit globally shadowed setting (#30092)

Browse Source 
Previously when attempting to edit a globally shadowed setting, the
error message was not very helpful, it said "You are not allowed to
change hidden settings". This commit changes the error message to
reflect the actual problem, which is that the setting is shadowed by
a global setting via ENV var.
This commit is contained in:
Martin Brennan
2024-12-04 13:41:32 +10:00
committed by GitHub
parent 8e2505c0e0
commit 9c5eb7952e
5 changed files with 35 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/controllers/admin/site_settings_controller.rb
View File

@ -49,6 +49,10 @@ class Admin::SiteSettingsController < Admin::AdminController
on_failed_policy(:setting_is_visible) do
raise Discourse::InvalidParameters, I18n.t("errors.site_settings.site_setting_is_hidden")
end
on_failed_policy(:setting_is_shadowed_globally) do
raise Discourse::InvalidParameters,
I18n.t("errors.site_settings.site_setting_is_shadowed_globally")
end
on_failed_policy(:setting_is_configurable) do
raise Discourse::InvalidParameters,
I18n.t("errors.site_settings.site_setting_is_unconfigurable")