github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 10:28:20 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: cleanup chat desktop notification data (#28943)

Browse Source 
Makes channel_id and is_direct_message_channel consistent across desktop notifications, which also removes the need to lookup the channel from Chat Notification Manager.
This commit is contained in:
David Battersby
2024-10-03 12:43:17 +04:00
committed by GitHub
parent ad8f46f4f1
commit 9eaf908e63
7 changed files with 11 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/chat/test/javascripts/unit/lib/chat-audio-test.js
View File

@ -85,7 +85,7 @@ module("Discourse Chat | Unit | chat-audio", function (hooks) {
this.currentUser.user_option.chat_header_indicator_preference =
"dm_and_mentions";
this.handleNotification({ isDirectMessageChannel: true });
this.handleNotification({ is_direct_message_channel: true });
assert.ok(this.playStub.calledOnce);
});
@ -94,7 +94,7 @@ module("Discourse Chat | Unit | chat-audio", function (hooks) {
this.currentUser.user_option.chat_header_indicator_preference =
"dm_and_mentions";
this.handleNotification({ isDirectMessageChannel: false });
this.handleNotification({ is_direct_message_channel: false });
assert.ok(this.playStub.notCalled);
});