github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: all basic integer settings should have max value validation

Browse Source
This commit is contained in:
Arpit Jalan
2017-04-20 13:19:50 +05:30
parent 94c7be3ca6
commit 9eff4f0807
3 changed files with 30 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/components/validators/integer_setting_validator_spec.rb
View File

@ -21,9 +21,21 @@ describe IntegerSettingValidator do
it "returns true if value is a valid integer" do
expect(validator.valid_value?(1)).to eq(true)
expect(validator.valid_value?(-1)).to eq(true)
expect(validator.valid_value?('1')).to eq(true)
expect(validator.valid_value?('-1')).to eq(true)
end
it "defaults min to 0" do
expect(validator.valid_value?(-1)).to eq(false)
expect(validator.valid_value?('-1')).to eq(false)
expect(validator.valid_value?(0)).to eq(true)
expect(validator.valid_value?('0')).to eq(true)
end
it "defaults max to 20000" do
expect(validator.valid_value?(20001)).to eq(false)
expect(validator.valid_value?('20001')).to eq(false)
expect(validator.valid_value?(20000)).to eq(true)
expect(validator.valid_value?('20000')).to eq(true)
end
end