DEV: Move core plugin TL -> group settings (#25355)

* DEV: Change poll_minimum_trust_level_to_create to group based setting

New setting is poll_create_allowed_groups

c.f. https://meta.discourse.org/t/changes-coming-to-settings-for-giving-access-to-features-from-trust-levels-to-groups/283408

* DEV: Move styleguide_admin_only to group based setting

Not exactly a TL -> group change, but still part of the
overall effort here:

https://meta.discourse.org/t/changes-coming-to-settings-for-giving-access-to-features-from-trust-levels-to-groups/283408

New setting is styleguide_allowed_groups
This commit is contained in:
Martin Brennan
2024-01-23 11:35:14 +10:00
committed by GitHub
parent 678e3cfd25
commit a03f87bdbd
20 changed files with 124 additions and 30 deletions

View File

@ -376,7 +376,7 @@ RSpec.describe PostsController do
end
describe "regular user with insufficient trust level" do
before { SiteSetting.poll_minimum_trust_level_to_create = 2 }
before { SiteSetting.poll_create_allowed_groups = Group::AUTO_GROUPS[:trust_level_2] }
it "invalidates the post" do
log_in_user(Fabricate(:user, trust_level: 1, refresh_auto_groups: true))
@ -409,7 +409,7 @@ RSpec.describe PostsController do
end
describe "regular user with equal trust level" do
before { SiteSetting.poll_minimum_trust_level_to_create = 2 }
before { SiteSetting.poll_create_allowed_groups = Group::AUTO_GROUPS[:trust_level_2] }
it "validates the post" do
log_in_user(Fabricate(:user, trust_level: 2, refresh_auto_groups: true))
@ -424,7 +424,7 @@ RSpec.describe PostsController do
end
describe "regular user with superior trust level" do
before { SiteSetting.poll_minimum_trust_level_to_create = 2 }
before { SiteSetting.poll_create_allowed_groups = Group::AUTO_GROUPS[:trust_level_2] }
it "validates the post" do
log_in_user(Fabricate(:user, trust_level: 3, refresh_auto_groups: true))
@ -439,7 +439,7 @@ RSpec.describe PostsController do
end
describe "staff with insufficient trust level" do
before { SiteSetting.poll_minimum_trust_level_to_create = 2 }
before { SiteSetting.poll_create_allowed_groups = Group::AUTO_GROUPS[:trust_level_2] }
it "validates the post" do
log_in_user(Fabricate(:user, moderator: true, trust_level: 1))
@ -454,7 +454,7 @@ RSpec.describe PostsController do
end
describe "staff editing posts of users with insufficient trust level" do
before { SiteSetting.poll_minimum_trust_level_to_create = 2 }
before { SiteSetting.poll_create_allowed_groups = Group::AUTO_GROUPS[:trust_level_2] }
it "validates the post" do
log_in_user(Fabricate(:user, trust_level: 1, refresh_auto_groups: true))