github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 09:42:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Improve max-height value on toolbar popup menu (#18030)

Browse Source 
* UX: Improve `max-height` value on toolbar popup menu

* UX: Popup menu based on new editor height property

* DEV: Update heights on resize

* DEV: Remove `--d-editor-height` property

* UX: Calculate max height based on composer type

* DEV: Remove event listener `willDestroyElement()` hook

* FIX: Remove unnecessary check and calculation

* DEV: Remove explicitly calling `updateHeightOnViewportResize()`

* UX: Update max-height

* UX: Different max-height values for reply/create

* DEV: Add comments for clarity

* DEV: Remove `updateHeightOnViewportResize()` event listener
This commit is contained in:
Keegan George
2022-08-29 12:59:35 -07:00
committed by GitHub
parent eba8b8d34d
commit a046f0306a
3 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/stylesheets/common/select-kit/toolbar-popup-menu-options.scss
View File

@ -2,7 +2,7 @@
&.dropdown-select-box { &.dropdown-select-box {
&.toolbar-popup-menu-options { &.toolbar-popup-menu-options {
.select-kit-collection { .select-kit-collection {
max-height: 50vh; max-height: 35vh;
} }
.select-kit-body { .select-kit-body {

1
app/assets/stylesheets/mobile/select-kit/_index.scss
View File

@ -2,3 +2,4 @@
@import "dropdown-select-box"; @import "dropdown-select-box";
@import "select-kit"; @import "select-kit";
@import "tag-drop"; @import "tag-drop";
@import "toolbar-popup-menu-options";

16
app/assets/stylesheets/mobile/select-kit/toolbar-popup-menu-options.scss Normal file
View File

@ -0,0 +1,16 @@
// ensure popupmenu options has scroll behavior on limited screen space
#reply-control {
&.composer-action-createTopic {
.toolbar-popup-menu-options .select-kit-collection {
// fits popup menu inside textarea in create topic composer
max-height: 155px;
}
}
&.composer-action-reply {
.toolbar-popup-menu-options .select-kit-collection {
// fits popup menu to textarea in reply composer
max-height: 230px;
}
}
}