github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: De-arrowify tests (#11068)

Browse Source 
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
This commit is contained in:
Jarek Radosz
2020-10-30 17:37:32 +01:00
committed by GitHub
parent d5fb0b9435
commit a17d54d0bf
185 changed files with 762 additions and 762 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6
View File

@ -7,7 +7,7 @@ acceptance("Details Button", function (needs) {
needs.user();
needs.hooks.beforeEach(() => clearPopupMenuOptionsCallback());
test("details button", async (assert) => {
test("details button", async function (assert) {
const popupMenu = selectKit(".toolbar-popup-menu-options");
await visit("/");
@ -107,7 +107,7 @@ acceptance("Details Button", function (needs) {
);
});
test("details button surrounds all selected text in a single details block", async (assert) => {
test("details button surrounds all selected text in a single details block", async function (assert) {
const multilineInput = "first line\n\nsecond line\n\nthird line";
const popupMenu = selectKit(".toolbar-popup-menu-options");