github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 14:12:10 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: De-arrowify tests (#11068)

Browse Source 
Using arrow functions changes `this` context, which is undesired in tests, e.g. it makes it impossible to setup things like pretender (`this.server`) in `beforeEach` hooks.

Ember guides always use classic functions in examples (e.g. https://guides.emberjs.com/release/testing/test-types/), and that's what it uses in its own test suite, as do various addons and ember apps.

It was also already used in Discourse where `this` was required. Moving forward, it will be needed in more places as we migrate toward ember-cli.

(I might later add a custom rule to eslint-discourse-ember to enforce this)
This commit is contained in:
Jarek Radosz
2020-10-30 17:37:32 +01:00
committed by GitHub
parent d5fb0b9435
commit a17d54d0bf
185 changed files with 762 additions and 762 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/discourse-local-dates/test/javascripts/lib/date-with-zone-helper-test.js.es6
View File

@ -17,7 +17,7 @@ function buildDateHelper(params = {}) {
});
}
test("#format", (assert) => {
test("#format", function (assert) {
let date = buildDateHelper({
day: 15,
month: 2,
@ -28,7 +28,7 @@ test("#format", (assert) => {
assert.equal(date.format(), "2020-03-15T15:36:00.000+01:00");
});
test("#repetitionsBetweenDates", (assert) => {
test("#repetitionsBetweenDates", function (assert) {
let date;
date = buildDateHelper({
@ -96,7 +96,7 @@ test("#repetitionsBetweenDates", (assert) => {
);
});
test("#add", (assert) => {
test("#add", function (assert) {
let date;
let futureLocalDate;