DEV: Update display name in new quote format - Part 2 (#22104)

This change adds support retroactively updating display names in the new quote format when the user's name is changed. It happens through a background job that is triggered by a callback when a user is saved with a new name.
This commit is contained in:
Ted Johansson
2023-06-26 11:01:59 +08:00
committed by GitHub
parent 0b5d5b0d40
commit a183f14d09
7 changed files with 342 additions and 19 deletions

View File

@ -1,14 +1,11 @@
# frozen_string_literal: true
class QuoteRewriter
def initialize(user_id, old_username, new_username, avatar_img)
def initialize(user_id)
@user_id = user_id
@old_username = old_username
@new_username = new_username
@avatar_img = avatar_img
end
def rewrite_raw(raw)
def rewrite_raw_username(raw, old_username, new_username)
pattern =
Regexp.union(
/(?<pre>\[quote\s*=\s*["'']?.*username:)#{old_username}(?<post>\,?[^\]]*\])/i,
@ -18,7 +15,7 @@ class QuoteRewriter
raw.gsub(pattern, "\\k<pre>#{new_username}\\k<post>")
end
def rewrite_cooked(cooked)
def rewrite_cooked_username(cooked, old_username, new_username, avatar_img)
pattern = /(?<=\s)#{PrettyText::Helpers.format_username(old_username)}(?=:)/i
cooked
@ -44,9 +41,33 @@ class QuoteRewriter
end
end
def rewrite_raw_display_name(raw, old_display_name, new_display_name)
pattern = /(?<pre>\[quote\s*=\s*["'']?)#{old_display_name}(?<post>\,[^\]]*username[^\]]*\])/i
raw.gsub(pattern, "\\k<pre>#{new_display_name}\\k<post>")
end
def rewrite_cooked_display_name(cooked, old_display_name, new_display_name)
pattern = /(?<=\s)#{PrettyText::Helpers.format_username(old_display_name)}(?=:)/i
cooked
.css("aside.quote")
.each do |aside|
next unless div = aside.at_css("div.title")
div.children.each do |child|
if child.text?
content = child.content
display_name_replaced = content.gsub!(pattern, new_display_name).present?
child.content = content if display_name_replaced
end
end
end
end
private
attr_reader :user_id, :old_username, :new_username, :avatar_img
attr_reader :user_id
def quotes_correct_user?(aside)
Post.exists?(topic_id: aside["data-topic"], post_number: aside["data-post"], user_id: user_id)