github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-23 23:21:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Update call sites using BaseStore#download but expecting exceptions (#21551)

Browse Source 
In #21498, we split `BaseStore#download` into a "safe" version which returns nil on errors, and an "unsafe" version which raises an exception, which was the old behaviour of `#download`.

This change updates call sites that used the old `#download`, which raised exceptions, to use the new `#download!` to preserve behaviour (and silence deprecation warnings.)

It also silences the deprecation warning in tests.
This commit is contained in:
Ted Johansson
2023-05-17 16:03:33 +08:00
committed by GitHub
parent 8d58b1c6b8
commit a2bc24456f
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/email/sender.rb
View File

@ -363,7 +363,7 @@ module Email
if attached_upload.local?
Discourse.store.path_for(attached_upload)
else
Discourse.store.download(attached_upload).path
Discourse.store.download!(attached_upload).path
end
@message_attachments_index[original_upload.sha1] = @message.attachments.size