github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 01:05:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: makes avatar non interactive in thread participants list (#23847)

Browse Source 
It was slightly surprising to have a user card show when click on a thread item list.

More over this commit does:
- moves chat/user-avatar to chat-user-avatar and converts it to gjs
- moves chat/thread/participants to chat-thread-participants
- rewrite the `toggleCheckIfPossible` modifier to only be applied when selecting messages, it prevents the click event to collide with the click of avatars in regular messages
This commit is contained in:
Joffrey JAFFEUX
2023-10-09 21:12:50 +02:00
committed by GitHub
parent 245e9f30a4
commit a39ff830e8
20 changed files with 134 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/chat/spec/system/page_objects/chat/components/thread_indicator.rb
View File

@ -33,7 +33,7 @@ module PageObjects
def has_participant?(user)
find(@context).has_css?(
".chat-thread-participants__avatar-group .chat-user-avatar .chat-user-avatar__container[data-user-card=\"#{user.username}\"] img",
".chat-thread-participants__avatar-group .chat-user-avatar[data-username=\"#{user.username}\"] img",
)
end