github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-18 04:03:13 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Clean up category-link (#24988)

Browse Source 
The `style` variable is always set because every category has a color
defined, so the surrounding if statement is unnecessary.

"+ X categories" option has also been removed in the past and the code
related to it is now dead code.
This commit is contained in:
Bianca Nenciu 2023-12-21 11:54:47 +02:00 committed by GitHub
parent 20f950a116
commit a3bd86f85c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/assets/javascripts/discourse/app/helpers/category-link.js
View File

@ -111,6 +111,7 @@ export function defaultCategoryLinkRenderer(category, opts) {
let href = opts.link === false ? "" : url; let href = opts.link === false ? "" : url;
let tagName = opts.link === false || opts.link === "false" ? "span" : "a"; let tagName = opts.link === false || opts.link === "false" ? "span" : "a";
let extraClasses = opts.extraClasses ? " " + opts.extraClasses : ""; let extraClasses = opts.extraClasses ? " " + opts.extraClasses : "";
let style = `${categoryVariables(category)}`;
let html = ""; let html = "";
let parentCat = null; let parentCat = null;
let categoryDir = ""; let categoryDir = "";
@ -172,18 +173,7 @@ export function defaultCategoryLinkRenderer(category, opts) {
href = ` href="${href}" `; href = ` href="${href}" `;
} }
let afterBadgeWrapper = ""; return `<${tagName} class="badge-category__wrapper ${extraClasses}" ${
style.length > 0 ? `style="${style}"` : ""
if (opts.plusSubcategories && opts.lastSubcategory) { } ${href}>${html}</${tagName}>`;
afterBadgeWrapper += `<span class="plus-subcategories">
${I18n.t("category_row.plus_subcategories", {
count: opts.plusSubcategories,
})}
</span>`;
}
const style = categoryVariables(category);
const extraAttrs = style.string ? `style="${style}"` : "";
return `<${tagName} class="badge-category__wrapper ${extraClasses}" ${extraAttrs} ${href}>${html}</${tagName}>${afterBadgeWrapper}`;
} }