github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-05 14:07:30 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: remove dangerous support for style/background attributes in polls

Browse Source
This commit is contained in:
Régis Hanol
2015-05-15 11:08:51 +02:00
parent fdbcc31a9c
commit a3fb2c002c
5 changed files with 8 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/poll/assets/javascripts/components/poll-results-standard.js.es6
View File

@ -3,19 +3,14 @@ export default Em.Component.extend({
classNames: ["results"],
options: function() {
const voters = this.get("poll.voters"),
backgroundColor = this.get("poll.background");
const voters = this.get("poll.voters");
this.get("poll.options").forEach(option => {
const percentage = voters === 0 ? 0 : Math.floor(100 * option.get("votes") / voters),
styles = ["width: " + percentage + "%"];
if (backgroundColor) { styles.push("background: " + backgroundColor); }
const percentage = voters === 0 ? 0 : Math.floor(100 * option.get("votes") / voters);
option.setProperties({
percentage,
title: I18n.t("poll.option_title", { count: option.get("votes") }),
style: styles.join(";").htmlSafe()
title: I18n.t("poll.option_title", { count: option.get("votes") })
});
});