github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 18:22:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: Improve errors when title is invalid (#11149)

Browse Source 
It used to simply say "title is invalid" without giving any hint what
the problem could be. This commit adds different errors messages for
all caps titles, low entropy titles or titles with very long words.
This commit is contained in:
Bianca Nenciu
2020-11-11 15:11:36 +02:00
committed by GitHub
parent ab314218d3
commit a48f7ba61c
4 changed files with 46 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/validators/quality_title_validator.rb
View File

@ -6,6 +6,17 @@ require 'text_cleaner'
class QualityTitleValidator < ActiveModel::EachValidator
def validate_each(record, attribute, value)
sentinel = TextSentinel.title_sentinel(value)
record.errors.add(attribute, :is_invalid) unless sentinel.valid?
if !sentinel.valid?
if !sentinel.seems_meaningful?
record.errors.add(attribute, :is_invalid_meaningful)
elsif !sentinel.seems_unpretentious?
record.errors.add(attribute, :is_invalid_unpretentious)
elsif !sentinel.seems_quiet?
record.errors.add(attribute, :is_invalid_quiet)
else
record.errors.add(attribute, :is_invalid)
end
end
end
end