UX: close thread panel with a single escape (#31426)

Before this commit we were requiring two escapes:
- one to un-focus composer
- one to close panel
This commit is contained in:
Joffrey JAFFEUX
2025-02-21 00:10:02 +01:00
committed by GitHub
parent c81d257961
commit a77d469eeb
2 changed files with 4 additions and 19 deletions

View File

@ -73,13 +73,8 @@ export default class ChatComposerThread extends ChatComposer {
return;
}
if (this.isFocused) {
event.stopPropagation();
this.composer.blur();
} else {
this.pane.close().then(() => {
this.channelComposer.focus();
});
}
this.pane.close().then(() => {
this.channelComposer.focus();
});
}
}

View File

@ -19,19 +19,9 @@ RSpec.describe "Chat | composer | shortcuts | thread", type: :system do
end
describe "Escape" do
context "when composer is focused" do
it "blurs the composer" do
chat_page.visit_thread(thread_1)
thread_page.composer.focus
thread_page.composer.cancel_shortcut
expect(side_panel_page).to have_open_thread
end
end
it "closes the thread panel" do
chat_page.visit_thread(thread_1)
thread_page.composer.cancel_shortcut # ensures we are not focused in the composer
page.send_keys(:escape)
expect(side_panel_page).to have_no_open_thread