FIX: Reject invalid Category slugs (#9473)

Previously it would sanitize given slug and then save the resulting empty slug.
This commit is contained in:
Jarek Radosz
2020-04-21 03:50:50 +02:00
committed by GitHub
parent 17cf300b71
commit a781ef7662
3 changed files with 11 additions and 10 deletions

View File

@ -376,14 +376,9 @@ RSpec.describe ListController do
# One category has another category's id at the beginning of its name
let!(:other_category) {
# Our validations don't allow this to happen now, but did historically
Fabricate(:category_with_definition, name: "#{category.id} name", slug: '-').tap { |c|
DB.exec <<~SQL
UPDATE categories
SET slug = '#{category.id}-name'
WHERE id = #{c.id}
SQL
c.reload
}
Fabricate(:category_with_definition, name: "#{category.id} name", slug: 'will-be-changed').tap do |category|
category.update_column(:slug, "#{category.id}-name")
end
}
it 'uses the correct category' do