github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: allow an admin to click on blank errors (#5027)

Browse Source 
* FIX: allow an admin to click on blank errors

* i18nlize strings

* what would a rails master do?
This commit is contained in:
Leo McArdle
2017-08-04 19:04:26 +01:00
committed by Régis Hanol
parent a3ef814245
commit a7b7fe335f
6 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/controllers/admin/email_controller_spec.rb
View File

@ -81,4 +81,22 @@ describe Admin::EmailController do
end
end
context '.rejected' do
it 'should provide a string for a blank error' do
Fabricate(:incoming_email, error: "")
xhr :get, :rejected
rejected = JSON.parse(response.body)
expect(rejected.first['error']).to eq(I18n.t("emails.incoming.unrecognized_error"))
end
end
context '.incoming' do
it 'should provide a string for a blank error' do
incoming_email = Fabricate(:incoming_email, error: "")
xhr :get, :incoming, id: incoming_email.id
incoming = JSON.parse(response.body)
expect(incoming['error']).to eq(I18n.t("emails.incoming.unrecognized_error"))
end
end
end