SECURITY: Add CSRF protections to OpenID callback

lib/auth/open_id_authenticator.rb

@@ -82,12 +82,25 @@ class Auth::OpenIdAuthenticator < Auth::Authenticator
 
   def register_middleware(omniauth)
     omniauth.provider :open_id,
-           setup: lambda { |env|
+         setup: lambda { |env|
-             strategy = env["omniauth.strategy"]
+           strategy = env["omniauth.strategy"]
-              strategy.options[:store] = OpenID::Store::Redis.new($redis)
+           strategy.options[:store] = OpenID::Store::Redis.new($redis)
-           },
+
-           name: name,
+           # Add CSRF protection in addition to OpenID Specification
-           identifier: identifier,
+           def strategy.query_string
-           require: "omniauth-openid"
+              session["omniauth.state"] = state = SecureRandom.hex(24)
+             "?state=#{state}"
+           end
+
+           def strategy.callback_phase
+             stored_state = session.delete("omniauth.state")
+             provided_state = request.params["state"]
+             return fail!(:invalid_credentials) unless provided_state == stored_state
+             super
+           end
+         },
+         name: name,
+         identifier: identifier,
+         require: "omniauth-openid"
   end
 end