github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 01:56:58 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: Test Memory Usage Fixes (#7769)

Browse Source 
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.

* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.

* `updateCurrentUser` is more accurate than `replaceCurrentUser`
This commit is contained in:
Robin Ward
2019-06-14 08:54:20 -04:00
committed by Joffrey JAFFEUX
parent c3381b845b
commit a8793d0d9a
23 changed files with 94 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/poll/test/javascripts/acceptance/poll-builder-enabled-test.js.es6
View File

@ -1,4 +1,4 @@
import { acceptance, replaceCurrentUser } from "helpers/qunit-helpers";
import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
import { displayPollBuilderButton } from "discourse/plugins/poll/helpers/display-poll-builder-button";
import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
@ -14,7 +14,7 @@ acceptance("Poll Builder - polls are enabled", {
});
test("regular user - sufficient trust level", assert => {
replaceCurrentUser({ staff: false, trust_level: 1 });
updateCurrentUser({ staff: false, trust_level: 1 });
displayPollBuilderButton();
@ -27,7 +27,7 @@ test("regular user - sufficient trust level", assert => {
});
test("regular user - insufficient trust level", assert => {
replaceCurrentUser({ staff: false, trust_level: 0 });
updateCurrentUser({ staff: false, trust_level: 0 });
displayPollBuilderButton();
@ -40,7 +40,7 @@ test("regular user - insufficient trust level", assert => {
});
test("staff - with insufficient trust level", assert => {
replaceCurrentUser({ staff: true, trust_level: 0 });
updateCurrentUser({ staff: true, trust_level: 0 });
displayPollBuilderButton();