github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-29 01:31:35 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: Test Memory Usage Fixes (#7769)

Browse Source 
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.

* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.

* `updateCurrentUser` is more accurate than `replaceCurrentUser`
This commit is contained in:
Robin Ward
2019-06-14 08:54:20 -04:00
committed by Joffrey JAFFEUX
parent c3381b845b
commit a8793d0d9a
23 changed files with 94 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/javascripts/acceptance/composer-uncategorized-test.js.es6
View File

@ -1,5 +1,5 @@
import selectKit from "helpers/select-kit-helper";
import { acceptance, replaceCurrentUser } from "helpers/qunit-helpers";
import { acceptance, updateCurrentUser } from "helpers/qunit-helpers";
acceptance("Composer and uncategorized is not allowed", {
loggedIn: true,
@ -18,7 +18,7 @@ acceptance("Composer and uncategorized is not allowed", {
});
QUnit.test("Disable body until category is selected", async assert => {
replaceCurrentUser({ admin: false, staff: false, trust_level: 1 });
updateCurrentUser({ admin: false, staff: false, trust_level: 1 });
await visit("/");
await click("#create-topic");