github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-01 03:25:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: Test Memory Usage Fixes (#7769)

Browse Source 
* Calling `Discourse.reset()` creates a new container
We should run our de-initializers only after acceptance tests,
since initializers are not run outside of acceptance tests anyway,
and the container at this point can be passed properly to the
`teardown()` method.

* Remove `Discourse.reset` from tests
This would cause a new container to be created which leaks many objects.

* `updateCurrentUser` is more accurate than `replaceCurrentUser`
This commit is contained in:
Robin Ward
2019-06-14 08:54:20 -04:00
committed by Joffrey JAFFEUX
parent c3381b845b
commit a8793d0d9a
23 changed files with 94 additions and 124 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/javascripts/acceptance/new-topic-test.js.es6
View File

@ -1,5 +1,5 @@
import selectKit from "helpers/select-kit-helper";
import { acceptance, logIn } from "helpers/qunit-helpers";
import { acceptance } from "helpers/qunit-helpers";
acceptance("New Topic");
@ -9,10 +9,8 @@ QUnit.test("accessing new-topic route when logged out", async assert => {
assert.ok(exists(".modal.login-modal"), "it shows the login modal");
});
acceptance("New Topic", { loggedIn: true });
QUnit.test("accessing new-topic route when logged in", async assert => {
logIn();
Discourse.reset();
await visit("/new-topic?title=topic%20title&body=topic%20body&category=bug");
assert.ok(exists(".composer-fields"), "it opens composer");