diff --git a/app/controllers/directory_items_controller.rb b/app/controllers/directory_items_controller.rb index d174571e67d..3f03ded0231 100644 --- a/app/controllers/directory_items_controller.rb +++ b/app/controllers/directory_items_controller.rb @@ -71,7 +71,7 @@ class DirectoryItemsController < ApplicationController load_more_directory_items_json = "#{load_more_uri.path}.json?#{load_more_uri.query}" # Put yourself at the top of the first page - if result.present? && current_user.present? && page == 0 + if result.present? && current_user.present? && page == 0 && !params[:group].present? position = result.index { |r| r.user_id == current_user.id } diff --git a/spec/requests/directory_items_controller_spec.rb b/spec/requests/directory_items_controller_spec.rb index df7042c9fbc..3fc5a4380c3 100644 --- a/spec/requests/directory_items_controller_spec.rb +++ b/spec/requests/directory_items_controller_spec.rb @@ -139,5 +139,14 @@ describe DirectoryItemsController do get '/directory_items.json', params: { period: 'all', group: group.name } expect(response.status).to eq(403) end + + it "does not force-include self in group-filtered results" do + me = Fabricate(:user) + DirectoryItem.refresh! + sign_in(me) + + get '/directory_items.json', params: { period: 'all', group: group.name } + expect(response.parsed_body['directory_items'].length).to eq(2) + end end end