diff --git a/app/controllers/admin/groups_controller.rb b/app/controllers/admin/groups_controller.rb index e56fe53c119..c8a328000d0 100644 --- a/app/controllers/admin/groups_controller.rb +++ b/app/controllers/admin/groups_controller.rb @@ -105,7 +105,7 @@ class Admin::GroupsController < Admin::AdminController end def remove_owner - group = Group.find_by(params.require(:id)) + group = Group.find_by(id: params.require(:id)) raise Discourse::NotFound unless group return can_not_modify_automatic if group.automatic diff --git a/spec/requests/admin/groups_controller_spec.rb b/spec/requests/admin/groups_controller_spec.rb index 20caa5b645d..7939a48f3b8 100644 --- a/spec/requests/admin/groups_controller_spec.rb +++ b/spec/requests/admin/groups_controller_spec.rb @@ -51,6 +51,19 @@ RSpec.describe Admin::GroupsController do end end + describe '#remove_owner' do + it 'should work' do + group.add_owner(user) + + delete "/admin/groups/#{group.id}/owners.json", params: { + user_id: user.id + } + + expect(response.status).to eq(200) + expect(group.group_users.where(owner: true)).to eq([]) + end + end + describe "#bulk_perform" do let(:group) do Fabricate(:group,