github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 18:22:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE - Moderators can create and manage groups (#10432)

Browse Source 
Enabling the moderators_manage_categories_and_groups site setting will allow moderator users to create/manage groups.

* show New Group form to moderators

* Allow moderators to update groups and read logs, where appropriate

* Rename site setting from create -> manage

* improved tests

* Migration should rename old log entries

* Log group changes, even if those changes mean you can no longer see the group

* Slight reshuffle

* RouteTo /g if they no longer have permissions to view group
This commit is contained in:
jbrw
2020-08-19 10:41:40 -04:00
committed by GitHub
parent 3640c00b03
commit aa1fc01307
29 changed files with 241 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/controllers/groups_controller.rb
View File

@ -140,11 +140,17 @@ class GroupsController < ApplicationController
def update
group = Group.find(params[:id])
guardian.ensure_can_edit!(group) unless current_user.admin
guardian.ensure_can_edit!(group) unless guardian.can_admin_group?(group)
if group.update(group_params(automatic: group.automatic))
GroupActionLogger.new(current_user, group).log_change_group_settings
render json: success_json
GroupActionLogger.new(current_user, group, skip_guardian: true).log_change_group_settings
if guardian.can_see?(group)
render json: success_json
else
# They can no longer see the group after changing permissions
render json: { route_to: '/g' }
end
else
render_json_error(group)
end
@ -511,7 +517,7 @@ class GroupsController < ApplicationController
def histories
group = find_group(:group_id)
guardian.ensure_can_edit!(group) unless current_user.admin
guardian.ensure_can_edit!(group) unless guardian.can_admin_group?(group)
page_size = 25
offset = (params[:offset] && params[:offset].to_i) || 0
@ -582,7 +588,7 @@ class GroupsController < ApplicationController
membership_request_template
}
if current_user.admin
if current_user.staff?
default_params.push(*[
:incoming_email,
:smtp_server,