github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 08:44:48 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: disables pointer events while showing menu (#22009)

Browse Source 
This commit attempts to have a bullet proof solution to the following case:

- long press on message (finger is still pressed)
- menu appears
- a button is now at finger location
- user releases finger
- a click is triggered on the button

Classic event canceling solution won't work here for performance reasons as we need the event to be passive in a scroll list.
This commit is contained in:
Joffrey JAFFEUX
2023-06-08 19:35:08 +02:00
committed by GitHub
parent ab260e70be
commit aa2270e4c3
3 changed files with 24 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/chat/spec/system/reply_to_message/mobile_spec.rb
View File

@ -40,14 +40,13 @@ RSpec.describe "Reply to message - channel - mobile", type: :system, mobile: tru
it "correctly loads the thread" do
chat_page.visit_channel(channel_1)
channel_page.reply_to(original_message)
thread_page.fill_composer("reply to message")
thread_page.click_send_message
thread_page.send_message("reply to message")
expect(thread_page).to have_message(text: "reply to message")
expect(thread_page.messages).to have_message(text: "reply to message")
refresh
expect(thread_page).to have_message(text: "reply to message")
expect(thread_page.messages).to have_message(text: "reply to message")
end
end
end