github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 23:36:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Infinite loop when poll step is zero (#5380)

Browse Source 
* Fix infinite loop when poll step is zero

* Add test for step minimum and for breaking test

* Remove trailing spaces (eslint)

* Remove extra space (eslint)

* Removed test call .twice
This commit is contained in:
Eric Berry
2017-11-30 09:04:41 -07:00
committed by Régis Hanol
parent 3f8d0c5c94
commit ab22c8cad4
5 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/poll/test/javascripts/controllers/poll-ui-builder-test.js.es6
View File

@ -196,6 +196,10 @@ test("number pollOutput", function(assert) {
controller.set("publicPoll", true);
assert.equal(controller.get("pollOutput"), "[poll type=number min=1 max=20 step=2 public=true]\n[/poll]", "it should return the right output");
controller.set("pollStep", 0);
assert.equal(controller.get("pollOutput"), "[poll type=number min=1 max=20 step=1 public=true]\n[/poll]", "it should return the right output");
});
test("regular pollOutput", function(assert) {