github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 07:11:34 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: bug when revoking badge as title (#8616)

Browse Source 
When user revokes badge as title, UserHistory item is created. However,
that object is not accepting revoke_reson parameter.
This commit is contained in:
Krzysztof Kotlarek
2019-12-24 08:03:51 +11:00
committed by GitHub
parent 63323bd7a8
commit ac626a0dc3
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/requests/users_controller_spec.rb
View File

@ -1943,6 +1943,14 @@ describe UsersController do
expect(user.user_profile.granted_title_badge_id).to eq(nil)
end
it "is not raising an erroring when user revokes title" do
sign_in(user)
badge.update allow_title: true
put "/u/#{user.username}/preferences/badge_title.json", params: { user_badge_id: user_badge.id }
put "/u/#{user.username}/preferences/badge_title.json", params: { user_badge_id: 0 }
expect(response.status).to eq(200)
end
context "with overrided name" do
fab!(:badge) { Fabricate(:badge, name: 'Demogorgon', allow_title: true) }
let(:user_badge) { BadgeGranter.grant(badge, user) }