github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 05:11:44 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Admin sidebar was hiding chat/forum toggle button (#25781)

Browse Source 
We have separated and combined modes for sidebar panels.
Separated means the panels show only their own sections,
combined means sections from all panels are shown.

The admin sidebar only shows its own panels, so it must set
the mode to separated; however when we navigate to chat or
home we must revert to the initial mode setttings.
This commit is contained in:
Martin Brennan
2024-02-21 14:44:09 +10:00
committed by GitHub
parent 95014e9ab8
commit ac92cc526d
4 changed files with 58 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
plugins/chat/spec/system/admin_sidebar_navigation_spec.rb
View File

@ -22,4 +22,31 @@ describe "Admin Revamp | Sidebar Navigation | Plugin Links", type: :system do
find(".header-sidebar-toggle").click
expect(sidebar).to have_section_link("Chat", href: "/admin/plugins/chat", count: 1)
end
describe "admin sidebar respects separated and combined sidebar modes" do
it "reverts to always (separated) mode after entering and leaving admin section" do
admin.user_option.update!(
chat_separate_sidebar_mode: UserOption.chat_separate_sidebar_modes[:always],
)
visit("/")
expect(sidebar).to have_switch_button("chat")
sidebar.click_link_in_section("community", "admin")
expect(sidebar).to have_no_switch_button("chat")
find("#site-logo").click
expect(sidebar).to have_switch_button("chat")
end
it "reverts to the never (combined) mode after entering and leaving admin section" do
admin.user_option.update!(
chat_separate_sidebar_mode: UserOption.chat_separate_sidebar_modes[:never],
)
visit("/")
expect(sidebar).to have_section("chat-channels")
expect(sidebar).to have_no_switch_button("chat")
sidebar.click_link_in_section("community", "admin")
expect(sidebar).to have_no_section("chat-channels")
find("#site-logo").click
expect(sidebar).to have_section("chat-channels")
end
end
end