From ad0a8cccc8c4360ca4423b952702fe2f0bc8bf46 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Tue, 6 Jun 2023 16:28:06 +0200 Subject: [PATCH] FIX: attempts to exit lock-on early (#21949) --- app/assets/javascripts/discourse/app/lib/lock-on.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/lib/lock-on.js b/app/assets/javascripts/discourse/app/lib/lock-on.js index 4f18588f3d6..1629f9c5606 100644 --- a/app/assets/javascripts/discourse/app/lib/lock-on.js +++ b/app/assets/javascripts/discourse/app/lib/lock-on.js @@ -120,9 +120,11 @@ export default class LockOn { return this.clearLock(); } - if (!within(4, top, this.previousTop) || !within(4, window.scrollY, top)) { + if (!within(4, top, this.previousTop)) { window.scrollTo(window.pageXOffset, top); this.previousTop = top; + } else { + return this.clearLock(); } // Stop early when maintaining the original offset