From ad32fa5690a0f889855044f85407dbef7dcad5e7 Mon Sep 17 00:00:00 2001 From: ftc2 Date: Wed, 5 Apr 2023 06:50:01 -0500 Subject: [PATCH] FIX: phpBB3 importer created invalid quote for posts (#20646) for proper quotes (those including a valid reference to a source post), the importer failed to yield a username, and the imported quote was broken. --- script/import_scripts/phpbb3/support/bbcode/xml_to_markdown.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/script/import_scripts/phpbb3/support/bbcode/xml_to_markdown.rb b/script/import_scripts/phpbb3/support/bbcode/xml_to_markdown.rb index 004601d2471..9fee2e8cd91 100644 --- a/script/import_scripts/phpbb3/support/bbcode/xml_to_markdown.rb +++ b/script/import_scripts/phpbb3/support/bbcode/xml_to_markdown.rb @@ -203,7 +203,8 @@ module ImportScripts::PhpBB3::BBCode def quoted_post(xml_node) if @quoted_post_from_post_id post_id = to_i(xml_node.attr("post_id")) - @quoted_post_from_post_id.call(post_id) if post_id + username = quoted_username(xml_node) + @quoted_post_from_post_id.call(post_id).merge({ username: username }) if post_id && username end end