UX: Always show avatar on mobile topic lists (#15323)

app/assets/javascripts/discourse/app/components/basic-topic-list.js

@@ -6,8 +6,6 @@ export default Component.extend({
   loadingMore: alias("topicList.loadingMore"),
   loading: not("loaded"),
 
-  hideMobileAvatar: true,
-
   @discourseComputed("topicList.loaded")
   loaded() {
     let topicList = this.topicList;

app/assets/javascripts/discourse/app/components/topic-list-item.js

@@ -195,11 +195,6 @@ export default Component.extend({
     return false;
   },
 
-  @discourseComputed("expandPinned", "hideMobileAvatar")
-  showMobileAvatar(expandPinned, hideMobileAvatar) {
-    return !(hideMobileAvatar || expandPinned);
-  },
-
   showEntrance,
 
   click(e) {

app/assets/javascripts/discourse/app/templates/components/basic-topic-list.hbs

@@ -2,7 +2,6 @@
   {{#if topics}}
     {{topic-list
       showPosters=showPosters
-      hideMobileAvatar=hideMobileAvatar
       hideCategory=hideCategory
       topics=topics
       expandExcerpts=expandExcerpts

app/assets/javascripts/discourse/app/templates/components/topic-list.hbs

@@ -36,7 +36,6 @@
                       showTopicPostBadges=showTopicPostBadges
                       hideCategory=hideCategory
                       showPosters=showPosters
-                      hideMobileAvatar=hideMobileAvatar
                       showLikes=showLikes
                       showOpLikes=showOpLikes
                       expandGloballyPinned=expandGloballyPinned

app/assets/javascripts/discourse/app/templates/mobile/list/topic-list-item.hbr

@@ -1,13 +1,9 @@
 <td class="topic-list-data">
   {{~raw-plugin-outlet name="topic-list-before-columns"}}
-  {{~#if showMobileAvatar}}
   <div class='pull-left'>
     <a href="{{topic.lastPostUrl}}" data-user-card="{{topic.last_poster_username}}">{{avatar topic.lastPosterUser imageSize="large"}}</a>
   </div>
   <div class='right'>
-    {{else}}
-      <div>
-        {{/if~}}
     {{!--
       The `~` syntax strip spaces between the elements, making it produce
       `<a class=topic-post-badges>Some text</a><span class=topic-post-badges>`,