github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-02 04:08:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Make params explicit for services in controllers

Browse Source
This commit is contained in:
Loïc Guitaut
2024-10-02 16:07:57 +02:00
committed by Loïc Guitaut
parent 3108e3a6b6
commit ad8f46f4f1
28 changed files with 52 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/admin/admin_notices_controller.rb
View File

@ -2,7 +2,7 @@
class Admin::AdminNoticesController < Admin::StaffController
def destroy
AdminNotices::Dismiss.call do
AdminNotices::Dismiss.call(service_params) do
on_success { render(json: success_json) }
on_failure { render(json: failed_json, status: 422) }
end

10
app/controllers/admin/config/flags_controller.rb
View File

@ -2,7 +2,7 @@
class Admin::Config::FlagsController < Admin::AdminController
def toggle
Flags::ToggleFlag.call do
Flags::ToggleFlag.call(service_params) do
on_success do
Discourse.request_refresh!
render(json: success_json)
@ -26,7 +26,7 @@ class Admin::Config::FlagsController < Admin::AdminController
end
def create
Flags::CreateFlag.call do
Flags::CreateFlag.call(service_params) do
on_success do
Discourse.request_refresh!
render json: result.flag, serializer: FlagSerializer, used_flag_ids: Flag.used_flag_ids
@ -41,7 +41,7 @@ class Admin::Config::FlagsController < Admin::AdminController
end
def update
Flags::UpdateFlag.call do
Flags::UpdateFlag.call(service_params) do
on_success do
Discourse.request_refresh!
render json: result.flag, serializer: FlagSerializer, used_flag_ids: Flag.used_flag_ids
@ -59,7 +59,7 @@ class Admin::Config::FlagsController < Admin::AdminController
end
def reorder
Flags::ReorderFlag.call do
Flags::ReorderFlag.call(service_params) do
on_success do
Discourse.request_refresh!
render(json: success_json)
@ -75,7 +75,7 @@ class Admin::Config::FlagsController < Admin::AdminController
end
def destroy
Flags::DestroyFlag.call do
Flags::DestroyFlag.call(service_params) do
on_success do
Discourse.request_refresh!
render(json: success_json)

2
app/controllers/admin/site_settings_controller.rb
View File

@ -39,7 +39,7 @@ class Admin::SiteSettingsController < Admin::AdminController
previous_value = value_or_default(SiteSetting.get(id)) if update_existing_users
UpdateSiteSetting.call(setting_name: id, new_value: value) do
UpdateSiteSetting.call(service_params.merge(setting_name: id, new_value: value)) do
on_success do
if update_existing_users
SiteSettingUpdateExistingUsers.call(id, result.new_value, previous_value)

4
app/controllers/admin/users_controller.rb
View File

@ -120,7 +120,7 @@ class Admin::UsersController < Admin::StaffController
end
def suspend
User::Suspend.call do
User::Suspend.call(service_params) do
on_success do
render_json_dump(
suspension: {
@ -315,7 +315,7 @@ class Admin::UsersController < Admin::StaffController
end
def silence
User::Silence.call do
User::Silence.call(service_params) do
on_success do
render_json_dump(
silence: {

4
app/controllers/application_controller.rb
View File

@ -1162,4 +1162,8 @@ class ApplicationController < ActionController::Base
def clean_xml
response.body.gsub!(XmlCleaner::INVALID_CHARACTERS, "")
end
def service_params
params.to_unsafe_h.merge(guardian:)
end
end