github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-26 09:42:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Improvements for theme UI (#5650)

Browse Source 
* Don't display "Settings: YAML" in Custom CSS/HTML section

* Don't show the settings tab for remote/imported themes
This commit is contained in:
OsamaSayegh
2018-03-06 01:26:50 +03:00
committed by Sam
parent 17a615165c
commit adc46ac56c
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/admin/controllers/admin-customize-themes-edit.js.es6
View File

@ -37,9 +37,9 @@ export default Ember.Controller.extend({
return this.shouldShow('mobile'); return this.shouldShow('mobile');
}, },
@computed('onlyOverridden') @computed('onlyOverridden', 'model.remote_theme')
showSettings() { showSettings() {
return this.shouldShow('settings'); return this.shouldShow('settings') && !this.get('model.remote_theme');
}, },
@observes('onlyOverridden') @observes('onlyOverridden')

2
app/assets/javascripts/admin/controllers/admin-customize-themes-show.js.es6
View File

@ -31,7 +31,7 @@ export default Ember.Controller.extend({
return text + ": " + localized.join(" , "); return text + ": " + localized.join(" , ");
} }
}; };
['common', 'desktop', 'mobile', 'settings'].forEach(target => { ['common', 'desktop', 'mobile'].forEach(target => {
descriptions.push(description(target)); descriptions.push(description(target));
}); });
return descriptions.reject(d=>Em.isBlank(d)); return descriptions.reject(d=>Em.isBlank(d));