github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-24 03:36:18 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Open links in external tabs. (#7444)

Browse Source
This commit is contained in:
Bianca Nenciu
2019-04-29 17:27:30 +03:00
committed by Penar Musaraj
parent ca9fd95a08
commit aef35faefc
2 changed files with 18 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/javascripts/lib/click-track-test.js.es6
View File

@ -115,16 +115,15 @@ QUnit.test(
);
QUnit.test("does not track clicks on lightboxes", async assert => {
var clickEvent = generateClickEventOn(".lightbox");
assert.ok(track(clickEvent));
assert.notOk(track(generateClickEventOn(".lightbox")));
});
QUnit.test("does not track clicks when forcibly disabled", async assert => {
assert.ok(track(generateClickEventOn(".no-track-link")));
assert.notOk(track(generateClickEventOn(".no-track-link")));
});
QUnit.test("does not track clicks on back buttons", async assert => {
assert.ok(track(generateClickEventOn(".back")));
assert.notOk(track(generateClickEventOn(".back")));
});
QUnit.test("does not track right clicks inside quotes", async assert => {
@ -134,11 +133,13 @@ QUnit.test("does not track right clicks inside quotes", async assert => {
});
QUnit.test("does not track clicks links in quotes", async assert => {
assert.ok(track(generateClickEventOn(".quote a:last-child")));
Discourse.User.currentProp("external_links_in_new_tab", true);
assert.notOk(track(generateClickEventOn(".quote a:last-child")));
assert.ok(window.open.calledWith("https://google.com", "_blank"));
});
QUnit.test("does not track clicks on category badges", async assert => {
assert.ok(track(generateClickEventOn(".hashtag")));
assert.notOk(track(generateClickEventOn(".hashtag")));
});
QUnit.test("does not track clicks on mailto", async assert => {