github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-07 15:56:02 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: In prod builds classes may not be "instancesof" EmberObject (#18137)

Browse Source 
They do have CoreObject in their prototype chain.

Fixes the issue mentioned in https://github.com/discourse/discourse-chat/pull/1204
This commit is contained in:
Jarek Radosz
2022-08-30 17:36:20 +02:00
committed by GitHub
parent 6570fed175
commit af7620cef8
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/assets/javascripts/discourse-common/addon/utils/handle-descriptor.js
View File

@ -1,10 +1,11 @@
import EmberObject, { computed, get } from "@ember/object"; import CoreObject from "@ember/object/core";
import { computed, get } from "@ember/object";
import extractValue from "./extract-value"; import extractValue from "./extract-value";
export default function handleDescriptor(target, key, desc, params = []) { export default function handleDescriptor(target, key, desc, params = []) {
const val = extractValue(desc); const val = extractValue(desc);
if (typeof val === "function" && target instanceof EmberObject) { if (typeof val === "function" && target instanceof CoreObject) {
// We're in a native class, so convert the method to a getter first // We're in a native class, so convert the method to a getter first
desc.writable = false; desc.writable = false;
desc.initializer = undefined; desc.initializer = undefined;