github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Possible 500 error if category saved incorrectly

Browse Source
This commit is contained in:
Robin Ward
2017-05-08 15:17:58 -04:00
parent 4f6e5fed2a
commit afe04b8bbb
2 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/controllers/list_controller_spec.rb
View File

@ -192,26 +192,34 @@ describe ListController do
end
describe "category default views" do
it "top default view" do
it "has a top default view" do
category.update_attributes!(default_view: 'top', default_top_period: 'monthly')
described_class.expects(:best_period_with_topics_for).with(anything, category.id, :monthly).returns(:monthly)
xhr :get, :category_default, category: category.slug
expect(response).to be_success
end
it "default view is nil" do
it "has a default view of nil" do
category.update_attributes!(default_view: nil)
described_class.expects(:best_period_for).never
xhr :get, :category_default, category: category.slug
expect(response).to be_success
end
it "default view is latest" do
it "has a default view of ''" do
category.update_attributes!(default_view: '')
described_class.expects(:best_period_for).never
xhr :get, :category_default, category: category.slug
expect(response).to be_success
end
it "has a default view of latest" do
category.update_attributes!(default_view: 'latest')
described_class.expects(:best_period_for).never
xhr :get, :category_default, category: category.slug
expect(response).to be_success
end
end
end
end