github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-02 16:29:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #4826 from techAPJ/site-setting-max-value

Browse Source 
FIX: all basic integer settings should have min & max value validation
This commit is contained in:
Arpit Jalan
2017-04-21 20:21:10 +05:30
committed by GitHub
parent 1f5089e474 9eff4f0807
commit b0151ab66a
3 changed files with 30 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
spec/components/validators/integer_setting_validator_spec.rb
View File

@ -21,9 +21,21 @@ describe IntegerSettingValidator do
it "returns true if value is a valid integer" do
expect(validator.valid_value?(1)).to eq(true)
expect(validator.valid_value?(-1)).to eq(true)
expect(validator.valid_value?('1')).to eq(true)
expect(validator.valid_value?('-1')).to eq(true)
end
it "defaults min to 0" do
expect(validator.valid_value?(-1)).to eq(false)
expect(validator.valid_value?('-1')).to eq(false)
expect(validator.valid_value?(0)).to eq(true)
expect(validator.valid_value?('0')).to eq(true)
end
it "defaults max to 20000" do
expect(validator.valid_value?(20001)).to eq(false)
expect(validator.valid_value?('20001')).to eq(false)
expect(validator.valid_value?(20000)).to eq(true)
expect(validator.valid_value?('20000')).to eq(true)
end
end