FEATURE: Split navigation preference for count and behavior of sidebar links (#22203)

This PR splits up the preference that controls the count vs dot and destination of sidebar links, which is really hard to understand, into 2 simpler checkboxes:

The new preferences/checkboxes are off by default, but there are database migrations to switch the old preference to the new ones so that existing users don't have to update their preferences to keep their preferred behavior of sidebar links when this changed is rolled out.

Internal topic: t/103529.
This commit is contained in:
Osama Sayegh
2023-06-22 19:04:13 +03:00
committed by GitHub
parent fcaa9757f3
commit b27e12445d
30 changed files with 788 additions and 249 deletions

View File

@ -18,14 +18,8 @@ module PageObjects
tag_selector_header.has_content?(tags.map(&:name).join(", "))
end
def has_navigation_menu_list_destination_preference?(type)
list_selector_header =
page.find(
".preferences-navigation-menu-navigation__list-destination-selector .select-kit-header-wrapper",
)
list_selector_header.has_content?(
I18n.t("js.user.experimental_sidebar.list_destination_#{type}"),
)
def has_navigation_menu_preference_checked?(preference)
page.find(".#{preference} input").checked?
end
end
end