github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-30 15:28:37 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix some openapi spec issues (#14037)

Browse Source 
- Remove duplicate paths
- Remove query param listed in the path
This commit is contained in:
Blake Erickson
2021-08-13 04:22:15 -06:00
committed by GitHub
parent c75500b871
commit b35695e411
2 changed files with 27 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
spec/requests/api/groups_spec.rb
View File

@ -125,13 +125,11 @@ describe 'groups' do
run_test!
end
end
end
path '/groups/{name}.json' do
get 'Get a group' do
tags 'Groups'
consumes 'application/json'
parameter name: :name, in: :path, type: :string
parameter name: :id, in: :path, type: :string, example: 'name', description: "Use group name instead of id"
expected_request_schema = nil
produces 'application/json'
@ -139,29 +137,7 @@ describe 'groups' do
expected_response_schema = load_spec_schema('group_response')
schema expected_response_schema
let(:name) { Fabricate(:group).name }
it_behaves_like "a JSON endpoint", 200 do
let(:expected_response_schema) { expected_response_schema }
let(:expected_request_schema) { expected_request_schema }
end
end
end
end
path '/groups/{name}/members.json' do
get 'List group members' do
tags 'Groups'
consumes 'application/json'
parameter name: :name, in: :path, type: :string
expected_request_schema = nil
produces 'application/json'
response '200', 'success response' do
expected_response_schema = load_spec_schema('group_members_response')
schema expected_response_schema
let(:name) { Fabricate(:group).name }
let(:id) { Fabricate(:group).name }
it_behaves_like "a JSON endpoint", 200 do
let(:expected_response_schema) { expected_response_schema }
@ -172,6 +148,26 @@ describe 'groups' do
end
path '/groups/{id}/members.json' do
get 'List group members' do
tags 'Groups'
consumes 'application/json'
parameter name: :id, in: :path, type: :string, example: 'name', description: "Use group name instead of id"
expected_request_schema = nil
produces 'application/json'
response '200', 'success response' do
expected_response_schema = load_spec_schema('group_members_response')
schema expected_response_schema
let(:id) { Fabricate(:group).name }
it_behaves_like "a JSON endpoint", 200 do
let(:expected_response_schema) { expected_response_schema }
let(:expected_request_schema) { expected_request_schema }
end
end
end
put 'Add group members' do
tags 'Groups'
consumes 'application/json'