github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-06-04 06:56:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: allow some auth token misses prior to clearing cookie

Browse Source 
It appears that in some cases ios queues up requests up front
and "releases" them when tab gets focus, this allows for a certain
number of cookie misses for this case. Otherwise you get logged off.
This commit is contained in:
Sam Saffron
2017-02-22 12:36:58 -05:00
parent 3532957ce1
commit b7d2edc7dc
2 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/components/auth/default_current_user_provider_spec.rb
View File

@ -201,9 +201,15 @@ describe Auth::DefaultCurrentUserProvider do
it "correctly removes invalid cookies" do
cookies = {"_t" => "BAAAD"}
provider('/').refresh_session(nil, {}, cookies)
cookies = {"_t" => SecureRandom.hex}
(Auth::DefaultCurrentUserProvider::MAX_COOKIE_MISSES).times do
provider('/').refresh_session(nil, {}, cookies)
end
expect(cookies.key?("_t")).to eq(true)
provider('/').refresh_session(nil, {}, cookies)
expect(cookies.key?("_t")).to eq(false)
end