github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-28 21:57:50 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: Don't calculate the same query twice.

Browse Source
This commit is contained in:
Guo Xiang Tan
2016-11-24 10:29:44 +08:00
parent 857955dd04
commit b889bfefbb
4 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/controllers/list_controller.rb
View File

@ -327,14 +327,20 @@ class ListController < ApplicationController
exclude_category_ids.pluck(:id)
end
def self.best_period_for(previous_visit_at, category_id=nil)
def self.best_period_with_topics_for(previous_visit_at, category_id=nil)
best_periods_for(previous_visit_at).each do |period|
top_topics = TopTopic.where("#{period}_score > 0")
top_topics = top_topics.joins(:topic).where("topics.category_id = ?", category_id) if category_id
return period if top_topics.count >= SiteSetting.topics_per_period_in_top_page
top_topics = top_topics.limit(SiteSetting.topics_per_period_in_top_page)
return period if top_topics.count == SiteSetting.topics_per_period_in_top_page
end
# default period is yearly
SiteSetting.top_page_default_timeframe.to_sym
false
end
def self.best_period_for(previous_visit_at, category_id=nil)
best_period_with_topics_for(previous_visit_at, category_id) ||
SiteSetting.top_page_default_timeframe.to_sym
end
def self.best_periods_for(date)