Convert specs to RSpec 2.99.2 syntax with Transpec

This conversion is done by Transpec 3.1.0 with the following command:
    transpec

* 424 conversions
    from: obj.should
      to: expect(obj).to

* 325 conversions
    from: == expected
      to: eq(expected)

* 38 conversions
    from: obj.should_not
      to: expect(obj).not_to

* 15 conversions
    from: =~ /pattern/
      to: match(/pattern/)

* 9 conversions
    from: it { should ... }
      to: it { is_expected.to ... }

* 5 conversions
    from: lambda { }.should_not
      to: expect { }.not_to

* 4 conversions
    from: lambda { }.should
      to: expect { }.to

* 2 conversions
    from: -> { }.should
      to: expect { }.to

* 2 conversions
    from: -> { }.should_not
      to: expect { }.not_to

* 1 conversion
    from: === expected
      to: be === expected

* 1 conversion
    from: =~ [1, 2]
      to: match_array([1, 2])

For more details: https://github.com/yujinakayama/transpec#supported-conversions

spec/controllers/groups_controller_spec.rb

@@ -91,10 +91,10 @@ describe GroupsController do
       Guardian.any_instance.stubs(:can_edit?).with(group).returns(false)
 
       xhr :put, :add_members, group_id: group.name, usernames: "bob"
-      response.should be_forbidden
+      expect(response).to be_forbidden
 
       xhr :delete, :remove_member, group_id: group.name, username: "bob"
-      response.should be_forbidden
+      expect(response).to be_forbidden
     end
 
     it "cannot add members to automatic groups" do
@@ -102,7 +102,7 @@ describe GroupsController do
       auto_group = Fabricate(:group, name: "auto_group", automatic: true)
 
       xhr :put, :add_members, group_id: group.name, usernames: "bob"
-      response.should be_forbidden
+      expect(response).to be_forbidden
     end
   end
 
@@ -119,42 +119,42 @@ describe GroupsController do
       user2 = Fabricate(:user)
       xhr :put, :add_members, group_id: group.name, usernames: user2.username
 
-      response.should be_success
+      expect(response).to be_success
       group.reload
-      group.users.count.should eq(2)
+      expect(group.users.count).to eq(2)
     end
 
     it "succeeds silently when adding non-existent users" do
       xhr :put, :add_members, group_id: group.name, usernames: "nosuchperson"
 
-      response.should be_success
+      expect(response).to be_success
       group.reload
-      group.users.count.should eq(1)
+      expect(group.users.count).to eq(1)
     end
 
     it "succeeds silently when adding duplicate users" do
       xhr :put, :add_members, group_id: group.name, usernames: @user1.username
 
-      response.should be_success
+      expect(response).to be_success
       group.reload
-      group.users.should eq([@user1])
+      expect(group.users).to eq([@user1])
     end
 
     it "can make incremental deletes" do
       xhr :delete, :remove_member, group_id: group.name, username: @user1.username
 
-      response.should be_success
+      expect(response).to be_success
       group.reload
-      group.users.count.should eq(0)
+      expect(group.users.count).to eq(0)
     end
 
     it "succeeds silently when removing non-members" do
       user2 = Fabricate(:user)
       xhr :delete, :remove_member, group_id: group.name, username: user2.username
 
-      response.should be_success
+      expect(response).to be_success
       group.reload
-      group.users.count.should eq(1)
+      expect(group.users.count).to eq(1)
     end
   end