From b92e4465f728451addc9bbf5ed8aab8e02deeef6 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 29 Oct 2019 16:01:15 +1100 Subject: [PATCH] DEV: stop depending on hover for image resize icons We no longer defer render the resize links, so we no longer need all these hover events to test it. Corrects broken test. --- .../acceptance/composer-test.js.es6 | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/test/javascripts/acceptance/composer-test.js.es6 b/test/javascripts/acceptance/composer-test.js.es6 index 004a4e29380..262146ab3d4 100644 --- a/test/javascripts/acceptance/composer-test.js.es6 +++ b/test/javascripts/acceptance/composer-test.js.es6 @@ -734,13 +734,6 @@ QUnit.test("Image resizing buttons", async assert => { await fillIn(".d-editor-input", uploads.join("\n")); - assert.ok( - find(".button-wrapper").length === 0, - "it does not append scaling buttons before hovering images" - ); - - await triggerEvent($(".d-editor-preview img"), "mouseover"); - assert.ok( find(".button-wrapper").length === 6, "it adds correct amount of scaling button groups" @@ -750,34 +743,24 @@ QUnit.test("Image resizing buttons", async assert => { await click(find(".button-wrapper .scale-btn[data-scale='50']")[0]); assertImageResized(assert, uploads); - await triggerEvent($(".d-editor-preview img"), "mouseover"); - uploads[2] = "![anotherOne|690x463,75%](upload://anotherOne.jpeg)"; await click(find(".button-wrapper .scale-btn[data-scale='75']")[1]); assertImageResized(assert, uploads); - await triggerEvent($(".d-editor-preview img"), "mouseover"); - uploads[7] = "![onTheSameLine1|200x200,50%](upload://onTheSameLine1.jpeg) ![onTheSameLine2|250x250](upload://onTheSameLine2.jpeg)"; await click(find(".button-wrapper .scale-btn[data-scale='50']")[2]); assertImageResized(assert, uploads); - await triggerEvent($(".d-editor-preview img"), "mouseover"); - uploads[7] = "![onTheSameLine1|200x200,50%](upload://onTheSameLine1.jpeg) ![onTheSameLine2|250x250,75%](upload://onTheSameLine2.jpeg)"; await click(find(".button-wrapper .scale-btn[data-scale='75']")[3]); assertImageResized(assert, uploads); - await triggerEvent($(".d-editor-preview img"), "mouseover"); - uploads[8] = "![identicalImage|300x300,50%](upload://identicalImage.png)"; await click(find(".button-wrapper .scale-btn[data-scale='50']")[4]); assertImageResized(assert, uploads); - await triggerEvent($(".d-editor-preview img"), "mouseover"); - uploads[9] = "![identicalImage|300x300,75%](upload://identicalImage.png)"; await click(find(".button-wrapper .scale-btn[data-scale='75']")[5]); assertImageResized(assert, uploads); @@ -791,8 +774,6 @@ QUnit.test("Image resizing buttons", async assert => { ` ); - await triggerEvent($(".d-editor-preview img"), "mouseover"); - assert.ok( find("script").length === 0, "it does not unescapes script tags in code blocks"