github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-21 18:12:32 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

automatic groups should not allow you to muck with the listed users in the group

Browse Source
This commit is contained in:
Sam
2013-06-17 12:54:25 +10:00
parent 7c73140674
commit b97d186cb5
7 changed files with 38 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
app/controllers/admin/groups_controller.rb
View File

@ -16,11 +16,14 @@ class Admin::GroupsController < Admin::AdminController
def update
group = Group.find(params[:id].to_i)
render_json_error if group.automatic
group.usernames = params[:group][:usernames]
group.name = params[:group][:name] if params[:name]
group.save!
render json: "ok"
if group.automatic
can_not_modify_automatic
else
group.usernames = params[:group][:usernames]
group.name = params[:group][:name] if params[:name]
group.save!
render json: "ok"
end
end
def create
@ -33,8 +36,17 @@ class Admin::GroupsController < Admin::AdminController
def destroy
group = Group.find(params[:id].to_i)
render_json_error if group.automatic
group.destroy
render json: "ok"
if group.automatic
can_not_modify_automatic
else
group.destroy
render json: "ok"
end
end
protected
def can_not_modify_automatic
render json: {errors: I18n.t('groups.errors.can_not_modify_automatic')}, status: 422
end
end