github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 22:43:33 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: if favicon is missing due to bad url we would return a 500 on favicons

Browse Source 
This ensures that the error logging does not corrupt the cache
This commit is contained in:
Sam Saffron
2019-06-05 16:43:40 +10:00
parent 62141b6316
commit b9df7a2257
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/controllers/static_controller.rb
View File

@ -143,6 +143,7 @@ class StaticController < ApplicationController
rescue => e rescue => e
AdminDashboardData.add_problem_message('dashboard.bad_favicon_url', 1800) AdminDashboardData.add_problem_message('dashboard.bad_favicon_url', 1800)
Rails.logger.warn("Failed to fetch faivcon #{favicon.url}: #{e}\n#{e.backtrace}") Rails.logger.warn("Failed to fetch faivcon #{favicon.url}: #{e}\n#{e.backtrace}")
""
ensure ensure
file&.unlink file&.unlink
end end