FIX: Don't fail silently.

2025-06-06 13:06:56 +08:00 · 2016-09-02 11:53:53 +08:00
parent efd7cbd887
commit baa6af93a2
1 changed files with 4 additions and 3 deletions
--- a/app/models/upload.rb
+++ b/app/models/upload.rb
@ -267,9 +267,10 @@ class Upload < ActiveRecord::Base
          end
          # store to new location & update the filesize
          File.open(path) do |f|
-            upload.url = Discourse.store.store_upload(f, upload)
-            upload.filesize = f.size
-            upload.save
+            upload.update_attributes!(
+              url: Discourse.store.store_upload(f, upload),
+              filesize: f.size
+            )
          end
          # remap the URLs
          DbHelper.remap(UrlHelper.absolute(previous_url), upload.url) unless external