FEATURE: flag dispositions normalization

All flags should end up in one of the three dispositions
  - Agree
  - Disagree
  - Defer

In the administration area, the *active* flags section displays 4 buttons
  - Agree (hide post + send PM)
  - Disagree
  - Defer
  - Delete

Clicking "Delete" will open a modal that offer to
  - Delete Post & Defer Flags
  - Delete Post & Agree with Flags
  - Delete Spammer (if available)

When the flag has a list associated, the list will now display 1
response and 1 reply and a "show more..." link if there are more in the
conversation. Replying to the conversation will NOT give a disposition.
Moderators must click the buttons that does that.

If someone clicks one buttons, this will add a default moderator message
from that moderator saying what happened.

The *old* flags section now displays the proper dispositions and is
super duper fast (no more N+9999 queries).

FIX: the old list includes deleted topics
FIX: the lists now properly display the topic states (deleted, closed,
archived, hidden, PM)
FIX: flagging a topic that you've already flagged the first post

spec/controllers/post_actions_controller_spec.rb

@@ -102,13 +102,13 @@ describe PostActionsController do
 
   end
 
-  context 'clear_flags' do
+  context 'defer_flags' do
 
     let(:flagged_post) { Fabricate(:post, user: Fabricate(:coding_horror)) }
 
     context "not logged in" do
       it "should not allow them to clear flags" do
-        lambda { xhr :post, :clear_flags }.should raise_error(Discourse::NotLoggedIn)
+        lambda { xhr :post, :defer_flags }.should raise_error(Discourse::NotLoggedIn)
       end
     end
 
@@ -116,43 +116,38 @@ describe PostActionsController do
       let!(:user) { log_in(:moderator) }
 
       it "raises an error without a post_action_type_id" do
-        -> { xhr :post, :clear_flags, id: flagged_post.id }.should raise_error(ActionController::ParameterMissing)
+        -> { xhr :post, :defer_flags, id: flagged_post.id }.should raise_error(ActionController::ParameterMissing)
       end
 
       it "raises an error when the user doesn't have access" do
-        Guardian.any_instance.expects(:can_clear_flags?).returns(false)
-        xhr :post, :clear_flags, id: flagged_post.id, post_action_type_id: PostActionType.types[:spam]
+        Guardian.any_instance.expects(:can_defer_flags?).returns(false)
+        xhr :post, :defer_flags, id: flagged_post.id, post_action_type_id: PostActionType.types[:spam]
         response.should be_forbidden
       end
 
       context "success" do
         before do
-          Guardian.any_instance.expects(:can_clear_flags?).returns(true)
-          PostAction.expects(:clear_flags!).with(flagged_post, user.id, PostActionType.types[:spam])
+          Guardian.any_instance.expects(:can_defer_flags?).returns(true)
+          PostAction.expects(:defer_flags!).with(flagged_post, user)
         end
 
-        it "delegates to clear_flags" do
-          xhr :post, :clear_flags, id: flagged_post.id, post_action_type_id: PostActionType.types[:spam]
+        it "delegates to defer_flags" do
+          xhr :post, :defer_flags, id: flagged_post.id, post_action_type_id: PostActionType.types[:spam]
           response.should be_success
         end
 
         it "works with a deleted post" do
           flagged_post.trash!(user)
-          xhr :post, :clear_flags, id: flagged_post.id, post_action_type_id: PostActionType.types[:spam]
+          xhr :post, :defer_flags, id: flagged_post.id, post_action_type_id: PostActionType.types[:spam]
           response.should be_success
         end
 
-
       end
 
     end
 
-
-
   end
 
-
-
   describe 'users' do
 
     let!(:post) { Fabricate(:post, user: log_in) }
@@ -188,6 +183,4 @@ describe PostActionsController do
 
   end
 
-
-
 end