github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-31 22:35:03 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FEATURE: optional quote sharing buttons (#10254)

Browse Source
This commit is contained in:
Penar Musaraj
2020-07-17 14:44:31 -04:00
committed by GitHub
parent 6e94f28cf0
commit bf22f7080d
15 changed files with 330 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

122
test/javascripts/acceptance/topic-quote-button-test.js Normal file
View File

@ -0,0 +1,122 @@
import I18n from "I18n";
import { acceptance } from "helpers/qunit-helpers";
function selectText(selector) {
const range = document.createRange();
const node = document.querySelector(selector);
range.selectNodeContents(node);
const selection = window.getSelection();
selection.removeAllRanges();
selection.addRange(range);
}
acceptance("Topic - Quote button - logged in", {
loggedIn: true,
settings: {
share_quote_visibility: "anonymous",
share_quote_buttons: "twitter|email"
}
});
QUnit.test("Does not show the quote share buttons by default", async assert => {
await visit("/t/internationalization-localization/280");
selectText("#post_5 blockquote");
assert.ok(exists(".insert-quote"), "it shows the quote button");
assert.equal(
find(".quote-sharing").length,
0,
"it does not show quote sharing"
);
});
QUnit.test(
"Shows quote share buttons with the right site settings",
async function(assert) {
this.siteSettings.share_quote_visibility = "all";
await visit("/t/internationalization-localization/280");
selectText("#post_5 blockquote");
assert.ok(exists(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.email")}']`),
"it includes the email share button"
);
}
);
acceptance("Topic - Quote button - anonymous", {
loggedIn: false,
settings: {
share_quote_visibility: "anonymous",
share_quote_buttons: "twitter|email"
}
});
QUnit.test(
"Shows quote share buttons with the right site settings",
async function(assert) {
await visit("/t/internationalization-localization/280");
selectText("#post_5 blockquote");
assert.ok(find(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.email")}']`),
"it includes the email share button"
);
assert.equal(
find(".insert-quote").length,
0,
"it does not show the quote button"
);
}
);
QUnit.test(
"Shows single share button when site setting only has one item",
async function(assert) {
this.siteSettings.share_quote_buttons = "twitter";
await visit("/t/internationalization-localization/280");
selectText("#post_5 blockquote");
assert.ok(exists(".quote-sharing"), "it shows the quote sharing options");
assert.ok(
exists(`.quote-sharing .btn[title='${I18n.t("share.twitter")}']`),
"it includes the twitter share button"
);
assert.equal(
find(".quote-share-label").length,
0,
"it does not show the Share label"
);
}
);
QUnit.test("Shows nothing when visibility is disabled", async function(assert) {
this.siteSettings.share_quote_visibility = "none";
await visit("/t/internationalization-localization/280");
selectText("#post_5 blockquote");
assert.equal(
find(".quote-sharing").length,
0,
"it does not show quote sharing"
);
assert.equal(
find(".insert-quote").length,
0,
"it does not show the quote button"
);
});

4
test/javascripts/acceptance/topic-test.js
View File

@ -341,7 +341,7 @@ function selectText(selector) {
QUnit.test("Quoting a quote keeps the original poster name", async assert => {
await visit("/t/internationalization-localization/280");
selectText("#post_5 blockquote");
await click(".quote-button");
await click(".quote-button .insert-quote");
assert.ok(
find(".d-editor-input")
@ -386,7 +386,7 @@ QUnit.test(
async assert => {
await visit("/t/internationalization-localization/280");
selectText("#post_5 .cooked");
await click(".quote-button");
await click(".quote-button .insert-quote");
assert.ok(
find(".d-editor-input")