github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-05-22 18:51:08 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Return a 404 when the draft_key is missing

Browse Source 
Previously if `draft_key` was missing you'd get a 500 error in the logs.
This commit is contained in:
Robin Ward
2020-02-14 10:48:56 -05:00
parent aad46a1aba
commit bfdd42c53a
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/draft_controller.rb
View File

@ -11,6 +11,8 @@ class DraftController < ApplicationController
end end
def update def update
raise Discourse::NotFound.new if params[:draft_key].blank?
sequence = sequence =
begin begin
Draft.set( Draft.set(

6
spec/requests/draft_controller_spec.rb
View File

@ -21,6 +21,12 @@ describe DraftController do
expect(Draft.get(user, 'xyz', 0)).to eq(%q({"my":"data"})) expect(Draft.get(user, 'xyz', 0)).to eq(%q({"my":"data"}))
end end
it "returns 404 when the key is missing" do
user = sign_in(Fabricate(:user))
post "/draft.json", params: { data: { my: "data" }.to_json, sequence: 0 }
expect(response.status).to eq(404)
end
it 'checks for an conflict on update' do it 'checks for an conflict on update' do
user = sign_in(Fabricate(:user)) user = sign_in(Fabricate(:user))
post = Fabricate(:post, user: user) post = Fabricate(:post, user: user)